New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NUX E2E tests #7165

Merged
merged 1 commit into from Jun 8, 2018

Conversation

Projects
None yet
3 participants
@noisysocks
Member

noisysocks commented Jun 6, 2018

Closes #7037.

Add a simple integration test which checks that a new user sees NUX tips.

How has this been tested?

npm run test-e2e

@noisysocks noisysocks changed the base branch from try/nux-tips to master Jun 7, 2018

Add NUX E2E tests
Add a simple test which checks that a new user sees NUX tips.

@noisysocks noisysocks requested a review from youknowriad Jun 7, 2018

@youknowriad

LGTM 👍

@noisysocks noisysocks merged commit 138c729 into master Jun 8, 2018

2 checks passed

codecov/project 46.6% remains the same compared to e809505
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@noisysocks noisysocks deleted the add/nux-e2e-tests branch Jun 8, 2018

@mtias mtias added this to the 3.1 milestone Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment