New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with formatting toolbar #7167

Merged
merged 1 commit into from Jun 6, 2018

Conversation

Projects
None yet
4 participants
@jasmussen
Contributor

jasmussen commented Jun 6, 2018

The right-border on the alignments was missing. This PR changes how we paint separators, so it gets fixed.

Verify this paints the right grouping borders for toolbar sections, both on mobile and desktop breakpoints, and with both the top-fixed toolbar and the block-fixed toolbar.

screen shot 2018-06-06 at 11 01 18


screen shot 2018-06-06 at 11 01 37


screen shot 2018-06-06 at 11 01 44

Fix regression with formatting toolbar
The right-border on the alignments was missing. This PR changes how we paint separators, so it gets fixed.

Verify this paints the right grouping borders for toolbar sections, both on mobile and desktop breakpoints, and with both the top-fixed toolbar and the block-fixed toolbar.

@jasmussen jasmussen added the [Type] Bug label Jun 6, 2018

@jasmussen jasmussen self-assigned this Jun 6, 2018

@jasmussen jasmussen requested a review from WordPress/gutenberg-core Jun 6, 2018

@tofumatt

What's the before scenario for this? Without an issue filed that this fixes or before screenshots it's hard to tell what this actually fixes… but the screenshots here look alright so I'll say okay.

But in the future if there's no issue, before screenshots would be grand 😁

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Jun 6, 2018

Thanks for the review, and good thoughts. Here's what's in master:

screen shot 2018-06-06 at 12 56 43

Note the missing separator between alignments and inline.

CC: @mcsf in case you would like to merge this.

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Jun 6, 2018

Fixes #7028

Cc @aduth

@mcsf mcsf merged commit 5984cdf into master Jun 6, 2018

2 checks passed

codecov/project 46.48% remains the same compared to 7c149d7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mcsf mcsf deleted the fix/toolbar-border-regression branch Jun 6, 2018

@ZebulanStanphill

This comment has been minimized.

Contributor

ZebulanStanphill commented Jun 7, 2018

I think this should be added to the 3.1 milestone?

@jasmussen jasmussen added this to the 3.1 milestone Jun 7, 2018

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Jun 7, 2018

Good catch, Zeb. It might actually go in a 3.0.2 milestone, but milestoning it 3.1 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment