New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gallery attachment page link #7185

Merged
merged 1 commit into from Jun 19, 2018

Conversation

Projects
None yet
2 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Jun 6, 2018

Fixes: #6896

Description

A simple fix we were not setting the link attribute. The link to attachment page was not working because the link attribute was not being set.

How has this been tested?

Add a gallery block; Add some images from the media gallery; On the block inspector, set the "Link to" option to the attachment page. Save the post. Verify the images correctly link to the attachment page.

@gziolo

gziolo approved these changes Jun 19, 2018

LGTM 👍

@gziolo gziolo added this to the 3.1 milestone Jun 19, 2018

@gziolo gziolo merged commit 9aeccef into master Jun 19, 2018

2 checks passed

codecov/project 46.39% remains the same compared to 5984cdf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the fix/fix-gallery-link-to-attachment-page branch Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment