New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update/block-settings-menu.expanded-label: Made label descriptive #7209

merged 2 commits into from Jun 8, 2018


None yet
3 participants

anevins12 commented Jun 7, 2018


The "More Options" changes its behaviour when its options are shown and the behaviour is changed to hide those options. This change of action now been reflected in the label of the button to say "Hide options".

Resolves #7204

How has this been tested?

  • Passes npm run test

Types of changes

  • JavaScript change


  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
@@ -83,7 +84,7 @@ export class BlockSettingsMenu extends Component {
} }
label={ __( 'More Options' ) }
label={ __( label ) }

This comment has been minimized.


ocean90 Jun 7, 2018


You can't pass variables to the i18n function. Should be const label = isOpen ? __( 'Hide Options' ) : __( 'More Options' ); in line 75.

This comment has been minimized.


anevins12 Jun 7, 2018




gziolo approved these changes Jun 8, 2018

Looks good, thanks for fixing 👍

PR was updated.

@gziolo gziolo merged commit ec7a0f4 into WordPress:master Jun 8, 2018

2 checks passed

codecov/project 46.62% (-0.01%) compared to 102445b
continuous-integration/travis-ci/pr The Travis CI build passed

@gziolo gziolo added this to the 3.1 milestone Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment