New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DotTip positioning fix #7219

Merged
merged 1 commit into from Jun 14, 2018

Conversation

Projects
None yet
4 participants
@noisysocks
Member

noisysocks commented Jun 8, 2018

Closes #7071. Add an official refresh() method to Popover so that DotTip can call this instead of relying on internal Popover methods.

To test:

  1. Delete GUTENBERG_NUX_1 from local storage
  2. Create a new post
  3. The tip should still be correctly positioned next to the inserter
Improve DotTip positioning fix
Add an official refresh() method to Popover so that DotTip can call this instead
of relying on internal Popover methods.

@noisysocks noisysocks added the NUX label Jun 8, 2018

@noisysocks noisysocks requested a review from youknowriad Jun 8, 2018

@youknowriad

Nice 👍

@noisysocks noisysocks merged commit f449352 into master Jun 14, 2018

2 checks passed

codecov/project 46.63% (+0.01%) compared to 138c729
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@noisysocks noisysocks deleted the fix/clean-up-nux-positioning-fix branch Jun 14, 2018

@mtias mtias added this to the 3.1 milestone Jun 20, 2018

### refresh
Calling `refresh()` will force the Popover to recalculate its size and position. This is useful when a DOM change causes the anchor node to change position.

This comment has been minimized.

@aduth

aduth Jul 30, 2018

Member

As a developer scanning only the code of the component, this comment would have been useful as a JSDoc of the refresh function itself. I didn't notice this documentation existed until I arrived here by git blame to complain 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment