Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix issues with floats and the side UI on wide and fullwide #7223
There are a few issues in master:
Edit: I added a few more fixes:
This PR fixes those. Screenshots:
Test on mobile and desktop, frontend and backend, that wide and fullwide and normal images and blocks look fine and don't cause horizontal scrollbars. Also test that floats behave as they should.
I left a few comments where we can consider some improvements, not blockers. Let me test it in the browser.
Great feedback. I created a new variable for the block container padding,
Great feedback. I pushed a fix to the mobile toolbar being cut on fullwide blocks:
I think because this PR has been in the queue for a bit, a separate refactor changed the behavior for the side UI to behave the same. That is, it shows up above the block instead, and in the case of the movers, they are hidden until the > 1000 breakpoint.
The argument for unification of those two is that themes might have a different implementation of "wide", so we need to be a bit more flexible with the side UI there. Whether it's good to hide the movers between 600 and 1000 I think is fair to look at separately.