Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't allow to start dragging blocks if a lock all exists #7225
If a template lock "all" exists, the block cannot be moved anywhere. In that case, we should not allow drag a block to start. In master we allow the block to dragged around, but it could not be dropped anywhere. This PR's avoids to drag&drop to start in this case.
How has this been tested?
I verified that if no locking exists the blocks can be dragged around.
changed the title from
Don't allow to start dragging blocks if a locking lock all exists
Don't allow to start dragging blocks if a lock all exists
Jun 8, 2018
I think a few documentation tweaks would be good here.
Also, "draggable" isn't technically a word. Maybe we could do
isAllowedToDrag or just anything else that wouldn't upset spellcheck
Nevermind, I can see it's already the name of the component and I'm late to that party. Still, a few documentation tweaks requested
In order to make not rendering BlockDraggable possible, a CSS rule was added that makes blocks hover and select area not dependent on BlockDraggable being present.
I'm not sure what these comments mean. If they could be clarified the code looks good; I just don't know about the comments.