New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages: Move Plugins module to packages #7235

Merged
merged 2 commits into from Jun 20, 2018

Conversation

Projects
None yet
2 participants
@gziolo
Member

gziolo commented Jun 8, 2018

Description

Part of #3955.

How has this been tested?

The following commands should work:

  • npm test
  • npm run dev
  • npm run build

Copy the following code into JS console: https://gist.github.com/gziolo/e2954aa83aa1f823b2b05ca1660c2223#file-my-plugin-es5-js. Make sure that sidebar plugins registers properly.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added this to the 3.1 milestone Jun 8, 2018

@gziolo gziolo self-assigned this Jun 8, 2018

@gziolo gziolo requested review from youknowriad and WordPress/gutenberg-core Jun 8, 2018

@@ -505,7 +505,7 @@ function gutenberg_register_scripts_and_styles() {
wp_register_script(
'wp-plugins',
gutenberg_url( 'build/plugins/index.js' ),
array( 'wp-element', 'wp-components', 'wp-utils', 'wp-data' ),
array( 'lodash', 'wp-element', 'wp-hooks' ),

This comment has been minimized.

@gziolo

gziolo Jun 8, 2018

Member

This is surprising! It was sort of broken but worked anyways ... :)

@Shelob9 Shelob9 referenced this pull request Jun 8, 2018

Closed

Packages: Publish all modules as independent npm packages #3955

19 of 19 tasks complete
@aduth

aduth approved these changes Jun 19, 2018

👍 (has merge conflict)

@gziolo

This comment has been minimized.

Member

gziolo commented Jun 20, 2018

Thanks, rebased with master.

@gziolo gziolo merged commit e440ca2 into master Jun 20, 2018

2 checks passed

codecov/project 46.87% remains the same compared to 5851831
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the update/move-plugins-packages branch Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment