Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Polish mobile toolbar #7278
This is very much an incremental and iterative improvement to the mobile toolbar & experience. It is not drastic at all, and further improvement is definitely needed. But it is one step on a path. It does this a few things.
Firstly, it adds a right border to the block toolbar, when that scrolls. Before you could get this:
Now you get this:
The above is still not ideal by any means, but it's, again, an iterative improvement.
It also removes transforms from the Block's "More" menu. I think that fixes #6449.
It polishes the mobile toolbar, and rearranges it so formatting is before mover and ellipsis:
This can perhaps be improved further, but keeping in mind the limitations of mobile safari this is still in the realm of improvements we can do now.
Finally, it removes the sibling inserter on mobile, because this interfered with tapping buttons, and it isn't that useful anyway given that you can see a "Add block" button right in the bottom toolbar.
Sure thing! In the future, you can request a re-review by selecting me for review again:
Doing it is more of a pain because the UI isn't amazing, but it means it shows up in my pull request queue as a review request assigned to me, which is easier to find and means I won't miss it, unlike a comment
Looks good to me; minor tweaks needed but after they're done I say it's good once the tests pass.