New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add es5 samples to edit-post and plugins #7290

Merged
merged 3 commits into from Jun 13, 2018

Conversation

Projects
None yet
2 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Jun 12, 2018

Description

This PR adds es5 samples to edit-post/README.md and plugins/README.md so developers can easily test the samples without any build system.

How has this been tested?

I verified in the browser console that the samples work as expected.

For some samples I add to add a final code block after the sample with the following format:

wp.plugins.registerPlugin( 'plugin-name', {
	icon: 'smiley',
	render: ###COMPONENT_TO_TEST###,
} );

gziolo added some commits Jun 13, 2018

@gziolo

gziolo approved these changes Jun 13, 2018

Looks great, nice improvement. I added small tweaks before merging 😎

@gziolo gziolo merged commit 2c9a288 into master Jun 13, 2018

2 checks passed

codecov/project 46.67% (-0.05%) compared to 4d3e3f6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta added this to the 3.1 milestone Jun 18, 2018

@gziolo gziolo deleted the add/es5-samples-edit-post-plugins branch Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment