New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let screen readers announce the block aria label #7305

Merged
merged 1 commit into from Jun 14, 2018

Conversation

Projects
None yet
4 participants
@IreneStr
Member

IreneStr commented Jun 14, 2018

Description

Let screen readers announce the block aria label. The aria label of the blocks used to be on an unfocusable div. We've moved it to the focussable parent div. As a result, the aria-label will be announced by screen readers when tabbing through the blocks.

I've paired on this with enejb

How has this been tested?

  • Use a screen reader, for example VoiceOver in combination with Safari.
  • Tab through the Gutenblocks of your post.
  • The screenreader should announce the block and its type.

Screenshots

schermafbeelding 2018-06-14 om 12 46 09
'groep' is Dutch for 'group'. It still has to be decided which role is most suitable. That's not part of this fix. (/cc @afercia )

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@youknowriad

Approved by @aduth

@youknowriad youknowriad merged commit 09f9334 into master Jun 14, 2018

2 checks passed

codecov/project 46.68% remains the same compared to f449352
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/5505-move-blocks-container-aria-label branch Jun 14, 2018

@jorgefilipecosta jorgefilipecosta added this to the 3.1 milestone Jun 14, 2018

@mtias mtias added the Accessibility label Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment