Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Made aria-multiline true by default in RichText #7306
There was a misunderstanding of what aria-multiline means. Currently, Gutenberg only used area-multiline true when multi lines could be inserted by pressing enter e.g.: the quote value and the caption of the image. Aria-multiline was set to false when RichText inputs could not have a new line inserted by pressing enter.
aria-multiline should be true in all the inputs with can have multiple lines rendered on the screen (behave like a text area) even if these lines were not created because of line breaks but because of line wrapping (not having space on display to show them in a single line). According to this interpretation, it looks like all the Gutenberg RichgText usage should use aria-multiline = true because all of our RichText use cases are more close to TextAreas to then single line input fields and they may have multiple lines rendered on a screen.
aria-multiline is now true by default in all RichText components.
How has this been tested?
I verified all RichText usages render aria-multiline=true in their dom nodes.
LGTM, we should include this new prop in README file before we proceed.