New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot test about `MoreMenu` component #7338

Merged
merged 2 commits into from Jun 20, 2018

Conversation

Projects
None yet
2 participants
@hideokamoto
Contributor

hideokamoto commented Jun 17, 2018

Description

Related to progress on the issue -> Unit Testing Components #641

Added some unit test scripts for MoreMenu component.

How has this been tested?

Run unit test command.

 PASS  edit-post/components/header/more-menu/test/index.js
  MoreMenu
    ✓ should match snapshot (87ms)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@gziolo

gziolo requested changes Jun 18, 2018 edited

There are a few coding style issues caught by Eslint, which were introduced in this PR:

/home/travis/build/WordPress/gutenberg/edit-post/components/header/more-menu/test/index.js
[0] 12:4 error There must be a space inside this paren space-in-parens
[0] 17:9 error There must be a space inside this paren space-in-parens
[0] 17:17 error There must be a space inside this paren space-in-parens
[0] 18:3 error There must be a space inside this paren space-in-parens
[0] 19:2 error There must be a space inside this paren space-in-parens
[0]
[0] ✖ 5 problems (5 errors, 0 warnings)
[0] 5 errors, 0 warnings potentially fixable with the --fix option.

They should be fixed before we can proceed.

@hideokamoto

This comment has been minimized.

Contributor

hideokamoto commented Jun 20, 2018

Oh, sorry. I've forgot to commit some update.
Now I've commit those update and pushed into the branch.

Thanks for reviewing :)

@gziolo

gziolo approved these changes Jun 20, 2018

@gziolo

This comment has been minimized.

Member

gziolo commented Jun 20, 2018

All good now, thanks 👍

@gziolo gziolo merged commit 81ba212 into WordPress:master Jun 20, 2018

2 checks passed

codecov/project 46.86% (+0.17%) compared to ae117ef
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo added this to the 3.1 milestone Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment