New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce `rendererPathWithAttributes()` for ServerSideRender #7371

Merged
merged 1 commit into from Jun 19, 2018

Conversation

Projects
None yet
3 participants
@danielbachhuber
Member

danielbachhuber commented Jun 19, 2018

This is a helper function to produce a path with the query arguments we
expect.

Follow-up from #7339

Introduce `rendererPathWithAttributes()` for ServerSideRender
This is a helper function to produce a path with the query arguments we
expect.

@danielbachhuber danielbachhuber added this to the 3.1 milestone Jun 19, 2018

@danielbachhuber danielbachhuber requested a review from youknowriad Jun 19, 2018

@youknowriad

Thanks for the follow-up, the updates look good, Let's wait for the tests to pass and merge

@chrisvanpatten

This comment has been minimized.

Contributor

chrisvanpatten commented Jun 19, 2018

Thanks for the help @danielbachhuber and @youknowriad :) Excited to see this get in!

@danielbachhuber danielbachhuber merged commit 67abc5b into master Jun 19, 2018

2 checks passed

codecov/project 46.62% (+<.01%) compared to 74842d0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the test-path-with-attributes branch Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment