New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Update demo content to avoid dirtying embed #7379

Merged
merged 1 commit into from Jun 19, 2018

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Jun 19, 2018

Related: #5315

This pull request seeks to update the demo post content to account for block replacement which would otherwise occur as a result of changes introduced in #5315, where a non-provider-specific embed will be replaced with its provider-specific variant if one exists. Without these changes, (a) the demo editor will present itself as dirtying and (b) will trigger an autosave to occur after 10 seconds.

Testing instructions:

  1. Navigate to Gutenberg > Demo
  2. Verify after a brief delay the reloading the page produces no "Changes exist" prompt

@aduth aduth added the Blocks label Jun 19, 2018

@aduth aduth requested a review from notnownikki Jun 19, 2018

@notnownikki

👍

@aduth aduth merged commit 555f2ea into master Jun 19, 2018

2 checks passed

codecov/project 46.62% remains the same compared to 5a65727
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aduth

This comment has been minimized.

Member

aduth commented Jun 19, 2018

Thanks for the review!

@aduth aduth deleted the update/post-content-embed branch Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment