Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Post author dropdown: add accessible-autocomplete #7385
How has this been tested?
Before this change, Gutenberg crashes on my 1 year old macbook pro:
After this change, Gutenberg loads fine and i can quickly search for the correct user. The default CSS included in the component needs some attention, but otherwise this is very usable.
Types of changes
Although this is a somewhat large PR, I believe we will find many benefits to having an accessible autocomplete component built into. this component is flexible enough to replace any select element we want to turn into a searchable autocomplete. In addition, I believe the use a
referenced this pull request
Jun 21, 2018
@adamsilverstein seems I'm not able to make this branch work. Maybe a few things have changed in Gutenberg, not sure.
I'd be happy to use the autocompleter from the UK Gov Digital Service, I'm just not able to test this PR
Generally, I'd highly recommend anything that comes from GDS as they're really committed to build accessible solutions. They've also already helped us on #5468 providing some precious feedback. /Cc @aduggin @tvararu
If this solves the performance issue, I'd say go with it!
I can see there's two functionality changes being delivered by this work; one is debouncing the search and changing the amount of results being pulled in, and the second is switching to accessible-autocomplete.
These changes touch the same feature but are otherwise independent, so would it make sense to deliver each as its own separate PR? That way the performance improvement can be shipped irrespective of the accessibility enhancements or vice-versa.
(Sorry for parachuting in with a review, feel free to ignore!)
is debouncing possible against the current implementation? it is a standard html select element.
I tried to test this since it's something that I would love to see implemented.But unfortunately, I can't make it work because there are some packages moved/removed in the latest Gutenberg core.
Also, wondering if it's OK to recreate this branch from 3.4.0 so I can come back with some real feedback.
Hi all :)
#10138 would need a lot of modification to achieve the goals set out for this PR, as it was centered around selecting multiple terms on an existing checkbox based UI. After looking through the discussions here, I think that getting this working with current master would be the best way forward. Otherwise, we'd just end up re-implementing this PR.
If no one has any objections, I can pick this up and see if I can get it working with current master. Thank you for your work here @adamsilverstein!