New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL: Fix block inserter popver in RTL mode by telling RTLCSS to ignore the relevent props #7429

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
3 participants
@yoavf
Contributor

yoavf commented Jun 21, 2018

Description

Prevent RTLCSS from reversing specific CSS rules related to left/right alignment of the popover component
Similar to #3911

Screenshots

Before:
screen shot 2018-06-21 at 14 19 51

After:
screen shot 2018-06-21 at 14 19 16

Types of changes

CSS comments to prevent automatic flipping of CSS properties.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@mtias mtias added this to the 3.1 milestone Jun 21, 2018

@aduth

aduth approved these changes Jun 21, 2018

LGTM 👍

@aduth aduth merged commit 56254e4 into WordPress:master Jun 21, 2018

2 checks passed

codecov/project 46.84% remains the same compared to 5389ada
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yoavf yoavf deleted the yoavf:update/editor-inserter-rtl branch Jun 21, 2018

@mtias mtias modified the milestones: 3.1, 3.2 Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment