New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add depends_on prop for images. #7451

Merged
merged 1 commit into from Sep 14, 2018

Conversation

Projects
None yet
2 participants
@torounit
Contributor

torounit commented Jun 21, 2018

Description

Setup order of service startup. create MySQL container before WordPress container.

see: Control startup order in Compose | Docker Documentation

How has this been tested?

Run docker-compose up . Check the order in which containers are created.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@aduth aduth requested review from pento and youknowriad Sep 13, 2018

@pento

pento approved these changes Sep 14, 2018

Awesome, thanks for the PR, @torounit!

@pento pento added the Build Tooling label Sep 14, 2018

@pento pento added this to the 3.9 milestone Sep 14, 2018

@pento pento merged commit 4754239 into WordPress:master Sep 14, 2018

2 checks passed

codecov/project 46.81% remains the same compared to 64a7c83
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment