New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Remove wrapping div from paragraph block #7477

Merged
merged 1 commit into from Jun 25, 2018

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Jun 22, 2018

This pull request is part of a performance audit of the paragraph block. It seeks to remove a wrapping div element which serves no purpose. It appears to have been originally used for assigning a node ref for use in a previous implementation of the contrast checker, which was later removed in #6088.

Implementation notes:

The changes may appear substantial, but it is merely the removal of the flattening of RichText by the removal of its div wrapper. No other changes are included.

Testing instructions:

Verify there are no regressions in the behavior of the paragraph block.

@gziolo

gziolo approved these changes Jun 22, 2018

I tried it a few weeks back and it worked just fine. We didn’t want to include it with other changes but I still think we should do it. 🚢

@gziolo gziolo added this to the 3.2 milestone Jun 25, 2018

@gziolo gziolo merged commit ae8f041 into master Jun 25, 2018

2 checks passed

codecov/project 46.8% remains the same compared to b16a8b2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aduth aduth deleted the remove/paragraph-wrapping-div branch Jun 25, 2018

oxyc added a commit to generoi/gutenberg that referenced this pull request Jun 26, 2018

Merge branch 'master' of https://github.com/WordPress/gutenberg
* 'master' of https://github.com/WordPress/gutenberg: (69 commits)
  fix: Show permalink editor in editor (WordPress#7494)
  Fix text wrapping in Firefox. (WordPress#7472)
  Try another approach to fixing the sibling inserter in Firefox (WordPress#7530)
  fix: Improve "add block" text in NUX onboarding (WordPress#7511)
  Implement core style of including revisions data on Post response (WordPress#7495)
  Testing: Add e2e test for PluginPostStatusInfo (WordPress#7284)
  Add end 2 end test for sidebar behaviours on mobile and desktop. (WordPress#6877)
  Only save metaboxes when it's not an autosave (WordPress#7502)
  Fix broken links in documentation (WordPress#7532)
  Remove post type 'viewable' compatibility shim (WordPress#7496)
  Fix typo. (WordPress#7528)
  Blocks: Remove wrapping div from paragraph block (WordPress#7477)
  fix: change import for InnerBlocks (WordPress#7484)
  Polish library just a teeeeensy bit (WordPress#7522)
  feat: Add snapshot update script (WordPress#7514)
  Display server error message when one exists (WordPress#7434)
  Fix issues with gallery in IE11. (WordPress#7465)
  Polish region focus style (WordPress#7459)
  Fix IE11 formatting toolbar visibility (WordPress#7413)
  Update plugin version to 3.1. (WordPress#7402)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment