From 66c1a18d55ef7d3921ae7845fb21321cfb8499cf Mon Sep 17 00:00:00 2001 From: "Matthew Riley MacPherson (tofumatt)" Date: Sat, 23 Jun 2018 17:37:18 +0100 Subject: [PATCH 1/3] fix: Improve "add block" text in NUX onboarding Fixes #7506 --- editor/components/default-block-appender/index.js | 2 +- .../default-block-appender/test/__snapshots__/index.js.snap | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/editor/components/default-block-appender/index.js b/editor/components/default-block-appender/index.js index 5a844824ba62..0c5835c676a8 100644 --- a/editor/components/default-block-appender/index.js +++ b/editor/components/default-block-appender/index.js @@ -59,7 +59,7 @@ export function DefaultBlockAppender( { - { __( 'Welcome to the wonderful world of blocks! Click ‘Add block’ to insert different kinds of content—text, images, quotes, video, lists, and much more.' ) } + { __( 'Welcome to the wonderful world of blocks! Click the “+” button (highlighted) to insert different kinds of content using blocks. There are blocks for text, images, lists, and more!' ) } diff --git a/editor/components/default-block-appender/test/__snapshots__/index.js.snap b/editor/components/default-block-appender/test/__snapshots__/index.js.snap index 9fee0c9ce14b..a17ea385e971 100644 --- a/editor/components/default-block-appender/test/__snapshots__/index.js.snap +++ b/editor/components/default-block-appender/test/__snapshots__/index.js.snap @@ -42,7 +42,7 @@ exports[`DefaultBlockAppender should append a default block when input focused 1 - Welcome to the wonderful world of blocks! Click ‘Add block’ to insert different kinds of content—text, images, quotes, video, lists, and much more. + Welcome to the wonderful world of blocks! Click the “+” button (highlighted) to insert different kinds of content using blocks. There are blocks for text, images, lists, and more! @@ -72,7 +72,7 @@ exports[`DefaultBlockAppender should match snapshot 1`] = ` - Welcome to the wonderful world of blocks! Click ‘Add block’ to insert different kinds of content—text, images, quotes, video, lists, and much more. + Welcome to the wonderful world of blocks! Click the “+” button (highlighted) to insert different kinds of content using blocks. There are blocks for text, images, lists, and more! @@ -102,7 +102,7 @@ exports[`DefaultBlockAppender should optionally show without prompt 1`] = ` - Welcome to the wonderful world of blocks! Click ‘Add block’ to insert different kinds of content—text, images, quotes, video, lists, and much more. + Welcome to the wonderful world of blocks! Click the “+” button (highlighted) to insert different kinds of content using blocks. There are blocks for text, images, lists, and more! From 499cd222fabc1b6551ae78c04c942bab272ee9d0 Mon Sep 17 00:00:00 2001 From: "Matthew Riley MacPherson (tofumatt)" Date: Mon, 25 Jun 2018 20:50:05 +0100 Subject: [PATCH 2/3] Tidy up text a bit, make it make sense with the off-screen text too --- editor/components/default-block-appender/index.js | 2 +- .../default-block-appender/test/__snapshots__/index.js.snap | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/editor/components/default-block-appender/index.js b/editor/components/default-block-appender/index.js index 0c5835c676a8..2943dbaa28f5 100644 --- a/editor/components/default-block-appender/index.js +++ b/editor/components/default-block-appender/index.js @@ -59,7 +59,7 @@ export function DefaultBlockAppender( { - { __( 'Welcome to the wonderful world of blocks! Click the “+” button (highlighted) to insert different kinds of content using blocks. There are blocks for text, images, lists, and more!' ) } + { __( 'Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to insert different kinds of content using blocks. There are blocks for text, images, lists, and more!' ) } diff --git a/editor/components/default-block-appender/test/__snapshots__/index.js.snap b/editor/components/default-block-appender/test/__snapshots__/index.js.snap index a17ea385e971..f7de56c33ee5 100644 --- a/editor/components/default-block-appender/test/__snapshots__/index.js.snap +++ b/editor/components/default-block-appender/test/__snapshots__/index.js.snap @@ -42,7 +42,7 @@ exports[`DefaultBlockAppender should append a default block when input focused 1 - Welcome to the wonderful world of blocks! Click the “+” button (highlighted) to insert different kinds of content using blocks. There are blocks for text, images, lists, and more! + Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to insert different kinds of content using blocks. There are blocks for text, images, lists, and more! @@ -72,7 +72,7 @@ exports[`DefaultBlockAppender should match snapshot 1`] = ` - Welcome to the wonderful world of blocks! Click the “+” button (highlighted) to insert different kinds of content using blocks. There are blocks for text, images, lists, and more! + Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to insert different kinds of content using blocks. There are blocks for text, images, lists, and more! @@ -102,7 +102,7 @@ exports[`DefaultBlockAppender should optionally show without prompt 1`] = ` - Welcome to the wonderful world of blocks! Click the “+” button (highlighted) to insert different kinds of content using blocks. There are blocks for text, images, lists, and more! + Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to insert different kinds of content using blocks. There are blocks for text, images, lists, and more! From 8f06539d1811e129100403a725d2aba1b873cee9 Mon Sep 17 00:00:00 2001 From: "Matthew Riley MacPherson (tofumatt)" Date: Mon, 25 Jun 2018 23:53:05 +0100 Subject: [PATCH 3/3] Use editorial-approved copy! --- editor/components/default-block-appender/index.js | 2 +- .../default-block-appender/test/__snapshots__/index.js.snap | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/editor/components/default-block-appender/index.js b/editor/components/default-block-appender/index.js index 2943dbaa28f5..292a4fc89ec2 100644 --- a/editor/components/default-block-appender/index.js +++ b/editor/components/default-block-appender/index.js @@ -59,7 +59,7 @@ export function DefaultBlockAppender( { - { __( 'Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to insert different kinds of content using blocks. There are blocks for text, images, lists, and more!' ) } + { __( 'Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to add a new block. There are blocks available for all kind of content: you can insert text, headings, images, lists, and lots more!' ) } diff --git a/editor/components/default-block-appender/test/__snapshots__/index.js.snap b/editor/components/default-block-appender/test/__snapshots__/index.js.snap index f7de56c33ee5..61f115611b1b 100644 --- a/editor/components/default-block-appender/test/__snapshots__/index.js.snap +++ b/editor/components/default-block-appender/test/__snapshots__/index.js.snap @@ -42,7 +42,7 @@ exports[`DefaultBlockAppender should append a default block when input focused 1 - Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to insert different kinds of content using blocks. There are blocks for text, images, lists, and more! + Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to add a new block. There are blocks available for all kind of content: you can insert text, headings, images, lists, and lots more! @@ -72,7 +72,7 @@ exports[`DefaultBlockAppender should match snapshot 1`] = ` - Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to insert different kinds of content using blocks. There are blocks for text, images, lists, and more! + Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to add a new block. There are blocks available for all kind of content: you can insert text, headings, images, lists, and lots more! @@ -102,7 +102,7 @@ exports[`DefaultBlockAppender should optionally show without prompt 1`] = ` - Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to insert different kinds of content using blocks. There are blocks for text, images, lists, and more! + Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to add a new block. There are blocks available for all kind of content: you can insert text, headings, images, lists, and lots more!