New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish library just a teeeeensy bit #7522

Merged
merged 1 commit into from Jun 25, 2018

Conversation

Projects
None yet
3 participants
@jasmussen
Contributor

jasmussen commented Jun 25, 2018

This PR does a few small things:

  • It removes the "scroll shadow" that sat at the bottom. This was always created for MacOS hiding scrollbars to indicate more content, but was more an issue before there were collapsible panels. It also broke the physics of the shadow.
  • It removes the bottom border on the last collapsible panel. That way it doesn't show a double border with the popover.
  • It tweaks the color of the Shared icon to be the same as all other icons, and it positions it so a panel with an icon is no taller than a panel without one.

Before:

screen shot 2018-06-25 at 09 28 32

After:

screen shot 2018-06-25 at 09 34 15

Polish library just a teeeeensy bit
This PR does a few small things:

- It removes the "scroll shadow" that sat at the bottom. This was always created for MacOS hiding scrollbars to indicate more content, but was more an issue before there were collapsible panels. It also broke the physics of the shadow.
- It removes the bottom border on the last collapsible panel. That way it doesn't show a double border with the popover.
- It tweaks the color of the Shared icon to be the same as all other icons, and it positions it so a panel with an icon is no taller than a panel without one.

@jasmussen jasmussen added the Design label Jun 25, 2018

@jasmussen jasmussen self-assigned this Jun 25, 2018

@jasmussen jasmussen requested review from karmatosed, mtias and WordPress/gutenberg-core Jun 25, 2018

@gziolo

gziolo approved these changes Jun 25, 2018

🚢

@jasmussen jasmussen added this to the 3.2 milestone Jun 25, 2018

@jasmussen jasmussen merged commit 70f7f8d into master Jun 25, 2018

2 checks passed

codecov/project 46.8% remains the same compared to b299f4f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the polish/library-shadows branch Jun 25, 2018

}
// Don't show the top border on the first panel, let the Search border be the border.
.components-panel__body:first-child {
border-top: none;
}
// Don't show the bottom border on the last panel, let hte library itself show the border.

This comment has been minimized.

@mtias

mtias Jun 25, 2018

Contributor

typo: "hte"

@jasmussen jasmussen referenced this pull request Jun 25, 2018

Merged

Fix typo. #7528

oxyc added a commit to generoi/gutenberg that referenced this pull request Jun 26, 2018

Merge branch 'master' of https://github.com/WordPress/gutenberg
* 'master' of https://github.com/WordPress/gutenberg: (69 commits)
  fix: Show permalink editor in editor (WordPress#7494)
  Fix text wrapping in Firefox. (WordPress#7472)
  Try another approach to fixing the sibling inserter in Firefox (WordPress#7530)
  fix: Improve "add block" text in NUX onboarding (WordPress#7511)
  Implement core style of including revisions data on Post response (WordPress#7495)
  Testing: Add e2e test for PluginPostStatusInfo (WordPress#7284)
  Add end 2 end test for sidebar behaviours on mobile and desktop. (WordPress#6877)
  Only save metaboxes when it's not an autosave (WordPress#7502)
  Fix broken links in documentation (WordPress#7532)
  Remove post type 'viewable' compatibility shim (WordPress#7496)
  Fix typo. (WordPress#7528)
  Blocks: Remove wrapping div from paragraph block (WordPress#7477)
  fix: change import for InnerBlocks (WordPress#7484)
  Polish library just a teeeeensy bit (WordPress#7522)
  feat: Add snapshot update script (WordPress#7514)
  Display server error message when one exists (WordPress#7434)
  Fix issues with gallery in IE11. (WordPress#7465)
  Polish region focus style (WordPress#7459)
  Fix IE11 formatting toolbar visibility (WordPress#7413)
  Update plugin version to 3.1. (WordPress#7402)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment