New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the button group button selector more specific #7533

Merged
merged 1 commit into from Jul 3, 2018

Conversation

Projects
None yet
3 participants
@chrisvanpatten
Contributor

chrisvanpatten commented Jun 25, 2018

Description

Makes the button group nested button selector more specific, so the border-radius property is applied correctly. Fixes #7531.

How has this been tested?

Manually in macOS Safari and Chrome

Screenshots

Before:

untitled____add_new_page mindful _wordpress

After:

untitled___ mindful _wordpress

Types of changes

Modifies a CSS selector to be more specific, resolving an issue introduced in ce61b59

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@chrisvanpatten

This comment has been minimized.

Contributor

chrisvanpatten commented Jun 25, 2018

(Travis failure seems unrelated…)

@danielbachhuber danielbachhuber requested a review from WordPress/gutenberg-core Jun 27, 2018

@danielbachhuber danielbachhuber added this to the 3.2 milestone Jun 27, 2018

@danielbachhuber

This comment has been minimized.

Member

danielbachhuber commented Jun 27, 2018

Travis failure is unrelated. I've restarted the job.

@aduth

aduth approved these changes Jul 3, 2018

Looks good 👍

@aduth aduth merged commit e69dca4 into WordPress:master Jul 3, 2018

2 checks passed

codecov/project 46.8% remains the same compared to bf69697
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chrisvanpatten chrisvanpatten deleted the TomodomoCo:fix/button-group-radius branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment