Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use color styles on the editor even if the classes were not set #7539
While for frontend view the current behaviour is the expected, on the editor is the themes passed us the color value we should use it even if the class was not created.
How has this been tested?
Add a palette that sets a color without implementing the class, verify the color was used in the editor.
Hi @gziolo thank you for the review!
I rebased, and the tests are now passing, I'm not sure why Travis was unhappy.
I'm not sure what you mean by "previous setup" I'm probably missing something. The only change we are doing in this PR is that before if we had a class for color, on the editor we just used the class without setting an inline style for the color. Right now, even if a color class exists we set an inline style anyway, so we are not dependent on the theme providing a class to show the colors on the editor correctly.