Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Move the remove icon button to the ellipsis menu as a menu button #7543
Fixes #7216, moves the remove icon button to the ellipsis menu as a menu button.
How has this been tested?
Types of changes
changed the title from
Update/block remove button
Move the remove icon button to the ellipsis menu as a menu button
Jun 26, 2018
Well, I thought adding a separator would be nice and easy, but there were a few intricacies:
referenced this pull request
Jun 27, 2018
Great work on this! It's looking really really close.
I'm not sure about re-using
MenuGroup in this way. I support the general idea but there's a few implications:
- We now have two
<div role="menu">s nested within a
<div role="menu">which feels a little weird to me.
<div role="menu">s have an
aria-labelledbyattribute which refers to an identifier that doesn't exist. Admittedly, this is probably a bug in
MenuGrouphas caused some regressions with
PluginSidebarMoreMenuItem, like you suspected it would:
- The extra padding—like you said
I notice that we have a
.editor-block-settings-menu__separator class defined already, so an alternative to
MenuGroup might be to simply use a div with that class to add the separator line. You can see an example of us doing exactly that in
Looks and works great! Thanks for working on this @talldan—and congrats on your first Gutentribution!
Since this bug already exists, let's address it in a seperate issue/PR.