New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ellipsis icon button is visible when block settings menu is open #7597

Merged
merged 1 commit into from Jul 2, 2018

Conversation

Projects
None yet
2 participants
@talldan
Contributor

talldan commented Jun 28, 2018

Description

Fixes #7596 - previously, while the block settings menu was open the ellipsis icon button could become hidden if it lost its hover state.

This change ensures the icon button remains visible while the menu is open.

When the block settings menu is not open, the icon button has the same behaviour as it did previously.

How has this been tested?

  • Manual UI testing
  • Ensured unit and e2e tests pass

Screenshots

ellipsis-fix

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
Ensure ellipsis icon button is visible when block settings menu is open
Previously, while the menu was open the ellipsis icon could become invisible if
it became unfocused or lost its hover state.

This change moves the is-visible class to apply to the icon button itself
instead of the containing `editor-block-settings-menu` element.

Additionally, the class is also present while the menu is open.

@talldan talldan self-assigned this Jun 28, 2018

@talldan talldan added the [Type] Bug label Jun 28, 2018

@talldan talldan requested a review from noisysocks Jun 28, 2018

@noisysocks

Works great! 👍

@noisysocks noisysocks added this to the 3.2 milestone Jul 2, 2018

@talldan talldan merged commit e5130f9 into master Jul 2, 2018

2 checks passed

codecov/project 47.26% remains the same compared to 41be78b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@talldan talldan deleted the fix/block-settings-menu-icon-visibility branch Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment