New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocks/index.js is compat with the RN so, use it #7599

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
2 participants
@hypest
Contributor

hypest commented Jun 28, 2018

Description

Removed the specialization-for-mobile of the blocks/index.js file.

How has this been tested?

Use wordpress-mobile/gutenberg-mobile#61 to test this PR by compiling and running the mobile GB app.

Screenshots

None

Types of changes

Dropped the native.js variant of the main Blocks index.js file as the web side one can normally be consumed by the mobile app now.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@gziolo

gziolo approved these changes Jun 28, 2018 edited

Not sure why Travis is failing. I restarted the node which gives some false negatives.

👍

@hypest

This comment has been minimized.

Contributor

hypest commented Jun 28, 2018

Travis greened out so, will merge. Thanks for the review and Travis re-trigger @gziolo 🙇‍♂️

@hypest hypest merged commit ef5cfe0 into master Jun 28, 2018

2 checks passed

codecov/project 47.26% (+<.01%) compared to 41be78b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hypest hypest deleted the rnmobile/no-need-for-native-block-api-indexjs branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment