New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Use cross-env for plugin build scripts #7615

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Jun 28, 2018

Regression introduced by #7493

This pull request seeks to resolve an issue where the build will fail on Windows machines, due to new additions to the plugin build to pass environment variables. We already use cross-env elsewhere for cross-platform compatibility, and it should have been used here as well.

Testing instructions:

Verify that there are no issues in building Gutenberg.

npm run build

@aduth aduth requested a review from azaozz Jun 28, 2018

@aduth aduth added the Build Tooling label Jun 28, 2018

@azaozz

This comment has been minimized.

Contributor

azaozz commented Jun 28, 2018

Works well :)

@azaozz

azaozz approved these changes Jun 28, 2018

Tested on Win 10-home. Works as expected.

@aduth aduth merged commit 2d3af44 into master Jun 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aduth aduth deleted the fix/build-cross-env-vars branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment