New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Docs: Try fixing the table of contents links 2nd attempt #7633

Merged
merged 2 commits into from Jul 3, 2018

Conversation

Projects
None yet
3 participants
@youknowriad
Contributor

youknowriad commented Jun 29, 2018

Apparently, the "child" filename should include the slug of the parent to make the links work properly in the handbook.

@youknowriad youknowriad self-assigned this Jun 29, 2018

@youknowriad youknowriad requested a review from gziolo Jun 29, 2018

@ntwb

This comment has been minimized.

Member

ntwb commented Jun 30, 2018

Maybe I am missing something but aren't these working fine in the handbook at the moment?

e.g. https://wordpress.org/gutenberg/handbook/packages/packages-data/packages-data-core/

@gziolo

gziolo approved these changes Jul 3, 2018

- [**core**: WordPress Core Data](../../docs/data/data-core.md)

This comment has been minimized.

@gziolo

gziolo Jul 3, 2018

Member

We should add a similar tweak for packages.

This comment has been minimized.

@gziolo

gziolo Jul 3, 2018

Member

Packages, are good. I wasn't aware, we don't copy over those documents.

@gziolo

This comment has been minimized.

Member

gziolo commented Jul 3, 2018

@ntwb it's for this page https://wordpress.org/gutenberg/handbook/data/ - all links are broken :(

@gziolo

This comment has been minimized.

Member

gziolo commented Jul 3, 2018

I noticed the following typo @wordpress/babel-plugin-import-jsx-pragam in the package name. To avoid such issues in the future, I added 7fa087a which automates discovery of packages.

@gziolo gziolo merged commit 20e7c58 into master Jul 3, 2018

2 checks passed

codecov/project 46.78% remains the same compared to 6526a96
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the try/fix-data-module-links branch Jul 3, 2018

@gziolo gziolo added this to the 3.2 milestone Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment