New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block List: Reenable pointer events on insertion point hover #7642

Merged
merged 1 commit into from Jul 2, 2018

Conversation

Projects
None yet
3 participants
@aduth
Member

aduth commented Jun 29, 2018

Alternative to #7530

This pull request seeks to resolve the issue with sibling inserter on FIrefox / Safari. The issue was that we make reenable visibility (opacity) of the insertion point on hover, but there are also pointer-events: none which were not also being reset on :hover. Not sure why the pointer-events are being reset in the first place.

Testing instructions:

Repeat testing instructions from #7530

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Jun 29, 2018

I don't understand how this fixes it, but if it does, holy guacamole is it prettier. I can't test now so if you'd like this in fast, feel free to expand the review range. 🎉

@jasmussen

I still don't understand how this fixes it, but I can confirm this fixes it for me in Firefox and Safari. Given it's so much prettier, ship it as fast as you can :)

@tofumatt

tofumatt approved these changes Jun 30, 2018 edited

Nice!

more-red-than-green

🚢

@@ -744,6 +744,7 @@
opacity: 0;
pointer-events: none;
&:hover,

This comment has been minimized.

@tofumatt

tofumatt Jun 30, 2018

Member

I tested this with the keyboard too and it worked, just FYI.

Cool thought, I wish I thought of this!

@aduth aduth merged commit 35a8399 into master Jul 2, 2018

2 checks passed

codecov/project 46.98% remains the same compared to 51c6ca7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment