Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Rich Text: Detect handled horizontal navigation by preventDefault #7644
This pull request seeks to improve upon the implementation of horizontal navigation in RichText from #6712. Per observation in #6712 (comment) , it finds a workaround to TinyMCE's calling of
Further, it avoids binding a
The revised implementation also seems to correct a potentially wrong behavior where collapsing a selection was wrongly causing the selection to be moved to a previous / next paragraph. This is reflected in updated end-to-end test with explaining comment.
Verify that you can traverse into and out of inline boundaries, including those which occur at the beginning or end of a paragraph.
Ensure end-to-end tests pass:
This is so much nicer! The code is easier to understand. Everything still works great for me.
I noticed the splitting of bold text with
return seems to work better too–it moved focus to the correct paragraph.
I can't run the e2e tests right now and feel bad blocking this on that.