Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Image Block 'Link to' setting #7679
Adds a new 'Link To' setting in the image block settings, similar to the 'Link To' option in the old editor.
Removes the old url editor toolbar option for the image block (this could be kept, though would need a bit of thought about how the two could co-exist)
How has this been tested?
Types of changes
Backwards compatibility with classic editor images.
@karmatosed I've made some changes along those lines. Since the input field with the url in it will always be visible, I've moved the two fields into their own section in the settings so that it feels contextually better. That feels a lot tidier to me and is also consistent with the new File Block. Here's a gif, let me know what you think:
I think there are a few minor things to address here first… also it would be nice if we could add tests for this, but I see there aren't any existing ones so perhaps that's a rabbit hole.