New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Address comments in #3911 #7690

Merged
merged 2 commits into from Jul 3, 2018

Conversation

Projects
None yet
2 participants
@tofumatt
Member

tofumatt commented Jul 3, 2018

This is just #3911 but with comments fixed. #3911 is approved but I couldn't push comments tweaks to it so it's here. 🤷‍♂️

Description

I merged #3911 but these are comment tweaks I requested in that PR.

@tofumatt tofumatt added this to the 3.2 milestone Jul 3, 2018

@tofumatt tofumatt requested review from WordPress/gutenberg-core and removed request for WordPress/gutenberg-core Jul 3, 2018

@ntwb

ntwb approved these changes Jul 3, 2018

@tofumatt

This comment has been minimized.

Member

tofumatt commented Jul 3, 2018

All that work to do this and then I merged the old PR absentmindedly. sigh 😔

tofumatt added some commits Jul 3, 2018

@tofumatt tofumatt changed the title from RTL: Fix left/right alignments of blocks to chore: Address comments in #3911 Jul 3, 2018

@tofumatt tofumatt merged commit a713494 into master Jul 3, 2018

2 checks passed

codecov/project 46.76% remains the same compared to b332ebd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tofumatt tofumatt deleted the yoavf-update/blocks-alignment-rtl branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment