Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Expose the grammar parser to the mobile app #7691
How has this been tested?
Besides successfully running
Types of changes
We need to decide what to do about #7664, where I proposed moving the parser and grammar to their own package and skip Webpack loader altogether. This will solve the issue with the code coverage, but more importantly, it will make this module to work independently to Webpack config when its published to npm.
Right. I think that ideally, we want to have a simple and robust way to expose the parser to both the web and the native mobile app. So, #7664 in on the right path, for many reasons.
That said, it's not clear to me yet how soon we'll get there so, this PR with its pre-generated parser is a solution that helps unblock work on the native mobile side.
I've already added tests for the pre-generated parser so, if it's OK with you and provided #7664 doesn't get merged this week, I'd prefer if we merge this PR and optimize on top of it. Let me know what you think @gziolo .