New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme support: Allow editor color palette to be empty #7708

Merged
merged 1 commit into from Jul 4, 2018

Conversation

Projects
None yet
2 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Jul 4, 2018

Description

With the merge of #7619 setting an empty array should set an empty color palette. I did some additional tests and I checked that it was not the case. This PR's fixes that.

How has this been tested?

I checked that adding add_theme_support( 'editor-color-palette' ) sets an empty color palette (same as in master).
I checked that adding add_theme_support( 'editor-color-palette', array() ); sets an empty color palette (in master it sets the default color palette)
I checked that for the previous cases If we add add_theme_support( 'disable-custom-colors' ); no color UI is available.
I checked that if 'editor-color-palette' is not specified, we use the default color palette.

@jorgefilipecosta jorgefilipecosta changed the title from Empty array sets empty color pallet to Small fix: Empty array sets empty color pallet Jul 4, 2018

@jorgefilipecosta jorgefilipecosta added this to the 3.2 milestone Jul 4, 2018

@mcsf mcsf changed the title from Small fix: Empty array sets empty color pallet to Small fix: Empty array sets empty color palette Jul 4, 2018

@mcsf mcsf changed the title from Small fix: Empty array sets empty color palette to Theme support: Allow editor color palette to be empty Jul 4, 2018

@mcsf

mcsf approved these changes Jul 4, 2018

@jorgefilipecosta jorgefilipecosta merged commit 28985e3 into master Jul 4, 2018

2 checks passed

codecov/project 46.46% remains the same compared to 6b5b57b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/empty-array-should-set-an-empty-color-pallete branch Jul 4, 2018

@jorgefilipecosta jorgefilipecosta self-assigned this Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment