Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: Check for forwardedRef in withGlobalEvents #7710
This seems to fix the problem in my tests, and given the severity of the bug, we should probably merge it.
That said I'm not certain if this is the best fix or not as I still don't have total context about what caused the problem. Maybe we can merge this for now and if we have a better solution later we can improve.
Jul 4, 2018
If folks would preferSetting it to
The no-op solution is more consistent and I considered it, I guess it's better in principle.
If your comments are in response to what I wrote above, I think what you have here is fine for now. I was mostly just thinking that the solution in the forwardRef work being done in #7557 could just set