Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Columns: Avoid re-render and subsequent action dispatch by adopting module constant #7720

Merged
merged 1 commit into from Jul 5, 2018
Merged

Columns: Avoid re-render and subsequent action dispatch by adopting module constant #7720

merged 1 commit into from Jul 5, 2018

Commits on Jul 5, 2018

  1. Improve the performance of the columns block 

    We were passing a new allowedBlocks reference on each column render. This dispatch additional unnecessary further actions to update inner block settings.
allowedBlocks reference should only be changed if, in fact, we are changing the allowedBlocks.
In the columns block, we can make allowed block a  constant given that it never changes.
    @jorgefilipecosta
    jorgefilipecosta committed Jul 5, 2018
    Copy the full SHA
    cfbff00 View commit details
    Browse the repository at this point in the history