Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Inner Blocks: Respecting locking in display of default block appender #7732
Alternative to #7723
This pull request seeks to resolve an issue where inserting a block which had full locking on its template would cause a default block to be appended because the DefaultBlockAppender's rendering was not conditional based on the locking settings of its layout context. This was only not obvious previously because we had a condition in the InnerBlocks to allow the template to synchronize itself on the basis of block count mismatch, so the templated blocks would be reset to its intended form after the default block was appended.
Repeat testing instructions from #7723
I like the changes here. They simplify the logic and solve the problem described in #7723 in a simpler way.
In my tests using https://gist.github.com/jorgefilipecosta/2bac096fe3be7f6ff0de7452292161cb things worked well.
And I verified on the dom for columns that we don't have a default appender while on master we have.