New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Drop deprecations slated for 3.2 removal #7747

Merged
merged 2 commits into from Jul 6, 2018

Conversation

Projects
None yet
4 participants
@aduth
Member

aduth commented Jul 6, 2018

This pull request seeks to remove deprecations slated for removal in the upcoming 3.2.0 release.

Specifically, this includes:

  • wp.data.withRehydratation has been renamed to wp.data.withRehydration.
  • The wp.editor.ImagePlaceholder component is removed. Please use wp.editor.MediaPlaceholder instead.
  • wp.utils.deprecated function removed. Please use wp.deprecated instead.
  • getInserterItems: the allowedBlockTypes argument was removed and the parentUID argument was added.
  • getFrecentInserterItems selector removed. Please use getInserterItems instead.
  • getSupportedBlocks selector removed. Please use canInsertBlockType instead.

See: https://wordpress.org/gutenberg/handbook/reference/deprecated/#3-2-0

Testing instructions:

Verify that there are no regressions in impacted behavior, and importantly that no references to deprecated behaviors exist in core code.

@aduth aduth added this to the 3.2 milestone Jul 6, 2018

@tofumatt tofumatt self-requested a review Jul 6, 2018

@tofumatt

Looks like utils/deprecated.js is slated to be removed but the file and function are still there: https://github.com/WordPress/gutenberg/blob/remove/3-2-deprecations/utils/deprecated.js

Otherwise looks good.

@jorgefilipecosta

This comment has been minimized.

Member

jorgefilipecosta commented Jul 6, 2018

I did some grepping and testing and things seem fine. I think the only thing missing is the removal of the deprecated wrapper from /utils/deprecated.

@mcsf

This comment has been minimized.

Contributor

mcsf commented Jul 6, 2018

We should mention this step of checking for deprecations in the release document.

@aduth

This comment has been minimized.

Member

aduth commented Jul 6, 2018

Looks like utils/deprecated.js is slated to be removed but the file and function are still there: https://github.com/WordPress/gutenberg/blob/remove/3-2-deprecations/utils/deprecated.js

Nice catch. Our custom lint rule is dumb and can't find by the aliased originalDeprecated, hence my missing it. It's been updated in 1c5f0a7.

@aduth

This comment has been minimized.

Member

aduth commented Jul 6, 2018

We should mention this step of checking for deprecations in the release document.

I might agree, but the document as written is more oriented to steps to undertake when already in the process of doing a release. Since the lint rule will forbid the merge of the version bump pull request anyways, I'm not sure it's of huge help. Maybe we should add a section on things to look out further ahead of the next release? (Maybe more as a step after a release)

@tofumatt

This comment has been minimized.

Member

tofumatt commented Jul 6, 2018

Easily solved with a Release Checklist section, which totally belongs in the release docs. 🚲🏠

@aduth

This comment has been minimized.

Member

aduth commented Jul 6, 2018

That would work, but only if it's the last step, not a pre-release step. Otherwise we risk reenforcing the idea that this be done at the time of a release, which I disagree with. 3.3 deprecations, for example, should ideally be removed immediately after the upcoming 3.2 release.

@aduth aduth merged commit dfb7b05 into master Jul 6, 2018

2 checks passed

codecov/project 48.46% (+0.05%) compared to c33bb2a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aduth aduth deleted the remove/3-2-deprecations branch Jul 6, 2018

@tofumatt

This comment has been minimized.

Member

tofumatt commented Jul 6, 2018

Oh, wait, right. Okay! I will add...

@@ -1,6 +1,6 @@
{
"name": "gutenberg",
"version": "3.1.1",
"version": "3.2.0",

This comment has been minimized.

@aduth

aduth Jul 6, 2018

Member

Sigh.. this wasn't meant to be included 😞 Only to help trigger the failing E2E locally.

This comment has been minimized.

@tofumatt

tofumatt Jul 6, 2018

Member

Sorry I missed it too 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment