Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some enzyme tests that involve HOCs to react-test-renderer (align.js) #7752

Merged

Conversation

Projects
None yet
2 participants
@nerrad
Copy link
Contributor

commented Jul 6, 2018

Description

This pull converts some editor/hooks/test/align.js tests to use react-test-renderer instead of enzyme. Any tests involving HOCs will break with the work in #7557 because of enzyme not supporting certain React 16.3+ features.

nerrad added some commits Jul 6, 2018

@nerrad nerrad requested review from aduth and gziolo Jul 6, 2018

@nerrad nerrad self-assigned this Jul 6, 2018

@gziolo

gziolo approved these changes Jul 9, 2018

Copy link
Member

left a comment

Lgtm 👍 nice nice nice, getting closer to have review queue smaller

@nerrad nerrad merged commit 22ae609 into master Jul 9, 2018

2 checks passed

codecov/project 48.46% remains the same compared to 3d009d2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nerrad nerrad deleted the update/convert-enzyme-tests-to-react-test-renderer-for-align branch Jul 9, 2018

@nerrad nerrad referenced this pull request Jul 9, 2018

Closed

remove test from being skipped (editor/hooks/test/align.js) #7837

4 of 4 tasks complete

@gziolo gziolo added this to the 3.3 milestone Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.