Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add link rel and link class to image block inspector (see #7504) #7771
This is some initial work towards addressing #7504. If there's interest from maintainers, I can proceed to add the 'Open link in a new tab' checkbox and investigate automated testing of these features.
How has this been tested?
Types of changes
New feature: adds image link
Good thoughts here. Rel is cool, especially because of the nofollow.
The media library interface is a little old at this point, and deserving of love. And there's also a very strong argument to make that this feature is a link feature, not just an image link feature, and as such should be an interface that is generic to all things that can be linked.
That should probably be the ultimate goal to strive towards, but in the mean time, it's probably okay to put this in the sidebar as the PR initially suggested, at least as a stepping stone towards greater things.
PR needs a rebase though.
Just a quick note that I've got a functioning version of this I can put in a separate branch if it's wanted. Was just figuring out how to best get it back into Github today.
Edit: I'll just go ahead and put it in a branch, because it was a significant amount of changes due to Gutenberg changes in the meantime. Will comment here when it's there.
It's referenced above, but I pushed the updated changes to this branch:
I currently only have the "Open in new tab" adding to
referenced this pull request
Oct 31, 2018
Hey @greatislander - Thanks for addressing all those comments, and sorry for the delay responding. This does look good, I gave it a test and it works really nicely.
I don't think the issue with the linkClass working in raw transforms was ever addressed. It'd be great if that could be created as a separate issue or PR.