Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usage and documentation of the landmark region labels. #7940

Merged
merged 1 commit into from Jul 15, 2018

Conversation

@afercia
Copy link
Contributor

commented Jul 12, 2018

Description

This PR aims to improve the aria-labels used for the navigable region landmarks and clarify their usage in the related README. Please refer to the related issue #7938 for more details.

  • changes the label "Editor toolbar" to "Editor top bar"
  • changes the label "Publish" to "Editor publish"

Worth reminding these labels are not visible and screen readers will automatically add the word "region" so they will announce:

  • "Editor top bar region"
  • "Editor publish region"

Also, adds some translators comments and clarifies the aria-label usage in the README.

Fixes #7938

How has this been tested?

npm test

@afercia afercia requested a review from jorgefilipecosta Jul 12, 2018

@jorgefilipecosta
Copy link
Member

left a comment

Looks good to me 👍 Thank you for this improvement.

On chrome, the Gutenberg landmark region navigator (control + ´/< ) is not working correctly now in my tests, but that regression was not caused by this PR.
Edited: it turns it was just my browser being weird after a restart things look fine.

@afercia afercia merged commit 8db4360 into master Jul 15, 2018

2 checks passed

codecov/project 49.41% remains the same compared to 82d46bf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mtias mtias added this to the 3.3 milestone Jul 20, 2018

@mtias mtias deleted the update/improve-navigable-region-landmark-labels branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.