Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add new RSS Block #7966
New Block to display RSS Feeds.
gziolo left a comment
Code wise it looks good. All my comments were addressed. Great work @Soean on RSS block. Thanks for updating PR instantly after all feedback received.
@mapk there is agreement that error state needs to get some improvement. There are some technical challenges which we need to look at first to get it done. Given that we still have more than a week until next planned Gutenberg release, I would suggest we merge this PR in the current shape and improve UI separately.
There is also possible improvements to tackle in the follow-up PR.
I agree about all your additional improvements, @gziolo as well.
and I have a 4th as Mel mentioned above.
Jan 25, 2019
1 check passed
added a commit
this pull request
Jan 25, 2019
Hey folks, not sure if this is the right place to ask (if not, let me know where would be best)...
What was the main reason for looking into adding this block to WordPress Core back in 2017?
I ask as the leader of the current team behind WP RSS Aggregator. I just came across this issue as we've been working on introducing our own Gutenberg block. Essentially, our free core version's block does exactly the same thing as this block, then the rest of our features and add-ons take it a step or two further.
I'm wondering what the future holds for this Gutenberg block to see if and how it may impact our plugin going forward. I've read the related Github issues but couldn't find what actually created the need for this feature to be in WordPress core. It would be great if I could hear some feedback on that and the future plans for the RSS block.
Hey @markzahra, this block is part of an effort to convert all existing core widgets into blocks. You can read more about that here: https://make.wordpress.org/core/2018/12/17/status-update-porting-widgets-to-blocks/
I don't think we'll do much beyond what's in this PR, except for maintenance.