Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Update test for babel-preset-default #7985

Merged
merged 1 commit into from Jul 18, 2018

Conversation

Projects
None yet
2 participants
@gziolo
Copy link
Member

commented Jul 16, 2018

Description

This PR updates test for babel-preset-default package to be snapshot based to ensure that transpilation works as expected. This new approach was suggested by @aduth over the existing test case.

How has this been tested?

npm test

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added this to the 3.3 milestone Jul 16, 2018

@gziolo gziolo self-assigned this Jul 16, 2018

@gziolo gziolo requested review from aduth and WordPress/gutenberg-core Jul 16, 2018

@aduth

aduth approved these changes Jul 18, 2018

Copy link
Member

left a comment

I don't really recall the original context for this one, but it seems like a strange and tedious thing to test. That said, what's here is better than what we have.

@aduth aduth modified the milestones: 3.3, 3.4 Jul 18, 2018

@gziolo gziolo merged commit 7ab5a9e into master Jul 18, 2018

2 checks passed

codecov/project 49.05% (-0.03%) compared to 15320bf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the update/babel-preset-test branch Jul 18, 2018

@aduth aduth modified the milestones: 3.4, 3.3 Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.