Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Enhancements to the color mechanism in accordance with the latest changes #7986
BREAKING CHANGE (with back compatibility).
The color mechanism suffered many changes since it was created. Namely the fact that now the identified for colors is not the name but a slug.
It applies some changes to make sure withColors now passed all the information contained in the color object as set by the themes to the blocks using withColors HOC.
The breaking change is that now the color code passed in objects by withColors is named as "color" instead of "value".
How has this been tested?
Verify the colors of the button and paragraph continue to work as before.
changed the title from
chore: Enhancements to the color mechanism in accordance with the latest changes
Enhancements to the color mechanism in accordance with the latest changes
Jul 27, 2018
I don't think this is as high priority as it's been flagged to be. Partly because it's not a documented utility† and its usage is likely very limited.
† Why isn't it documented?
Regarding the priority, I just made it a high priority because it was changing the API, but yes as it was not documented I agree the prioriy could be lower and I corrected it.
We had a pending PR that adds the documentation to this API. It was created before this PR, so I will update it and say it depends on this one being merged.
Themes set the color object with a color property. If we want to use value should themes also pass a value property?
Let's leave it as is for consistency
Please make sure to update deprecation versions before merging this PR.