New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Change color of links in gallery block caption #8004

Merged
merged 3 commits into from Aug 14, 2018

Conversation

Projects
None yet
6 participants
@nfmohit-wpmudev
Contributor

nfmohit-wpmudev commented Jul 17, 2018

Description

This PR addresses #7952 which reports the low readability links in image captions in the gallery block against the dark gradient background. This changes the default blue link color to white so that it is readable.

How has this been tested?

This has been tested by making sure the link color is white so that it is well readable against the dark gradient background, which turns to blue when the link background is changed to white when it is focused.

This was tested in WP 4.9.7, Gutenberg 3.2.0, Apache server with PHP 7.2.0 and MySQL 5.6.34. According to initial tests, the code doesn’t seem to affect any other areas.

Screenshots

pull-7952-min

Types of changes

This PR just adds CSS specific to the gallery block editor which changes the link color to white, and blue when it is focused, i.e. when the background turns white.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo requested a review from WordPress/gutenberg-core Aug 8, 2018

@gziolo gziolo added this to the 3.6 milestone Aug 8, 2018

@tofumatt

Good idea, thanks!

I think the code just needs tweaking. Let me know if you can make the changes @mtias and I suggested, but if not I can make them and merge this 👍

Show outdated Hide outdated core-blocks/gallery/editor.scss
@tofumatt

This comment has been minimized.

Show comment
Hide comment
@tofumatt

tofumatt Aug 8, 2018

Member

You're the best, I was literally just about to open this PR but it's great you got to it. Sorry for the delay! 😄

Member

tofumatt commented Aug 8, 2018

You're the best, I was literally just about to open this PR but it's great you got to it. Sorry for the delay! 😄

@nfmohit-wpmudev

This comment has been minimized.

Show comment
Hide comment
@nfmohit-wpmudev

nfmohit-wpmudev Aug 9, 2018

Contributor

Thank you @tofumatt ❤️ I'm sorry about the delay guys, thank you so much for the review ❤️

Contributor

nfmohit-wpmudev commented Aug 9, 2018

Thank you @tofumatt ❤️ I'm sorry about the delay guys, thank you so much for the review ❤️

@tofumatt

This comment has been minimized.

Show comment
Hide comment
@tofumatt

tofumatt Aug 9, 2018

Member

No worries, thanks so much! 👍

Member

tofumatt commented Aug 9, 2018

No worries, thanks so much! 👍

@tofumatt

This comment has been minimized.

Show comment
Hide comment
@tofumatt

tofumatt Aug 9, 2018

Member

I'm getting test failures locally too 😢

I wanted to get this merged but I'm not sure what's up with the failures. I'll have another look tomorrow, sorry.

Member

tofumatt commented Aug 9, 2018

I'm getting test failures locally too 😢

I wanted to get this merged but I'm not sure what's up with the failures. I'll have another look tomorrow, sorry.

@nfmohit-wpmudev

This comment has been minimized.

Show comment
Hide comment
@nfmohit-wpmudev

nfmohit-wpmudev Aug 9, 2018

Contributor

I tried taking a look but am not sure what went wrong. Weirdly, I didn't get any local test failures and I tested multiple times before the last commit 😕 Not sure why it'd fail over light visual CSS changes. Thanks for looking @tofumatt ❤️

Contributor

nfmohit-wpmudev commented Aug 9, 2018

I tried taking a look but am not sure what went wrong. Weirdly, I didn't get any local test failures and I tested multiple times before the last commit 😕 Not sure why it'd fail over light visual CSS changes. Thanks for looking @tofumatt ❤️

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Aug 9, 2018

Contributor

There were some tests failing yesterday due what seems like a race condition. See https://wordpress.slack.com/archives/C02QB2JS7/p1533732745000038

Contributor

jasmussen commented Aug 9, 2018

There were some tests failing yesterday due what seems like a race condition. See https://wordpress.slack.com/archives/C02QB2JS7/p1533732745000038

@tofumatt tofumatt merged commit 710cd9f into WordPress:master Aug 14, 2018

2 checks passed

codecov/project 50.3% remains the same compared to dab3fc1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nfmohit-wpmudev

This comment has been minimized.

Show comment
Hide comment
@nfmohit-wpmudev

nfmohit-wpmudev Aug 15, 2018

Contributor

Thank you @jasmussen and thank you for the merge @tofumatt ❤️

Contributor

nfmohit-wpmudev commented Aug 15, 2018

Thank you @jasmussen and thank you for the merge @tofumatt ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment