Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an edit button to embed blocks #8084

Merged
merged 2 commits into from Jul 26, 2018
Merged

Add an edit button to embed blocks #8084

merged 2 commits into from Jul 26, 2018

Conversation

@notnownikki
Copy link
Member

notnownikki commented Jul 20, 2018

Description

Adds an edit button to the embed blocks, so you can change the URL.

How has this been tested?

Embed some content, click the edit button, change the URL, embed again.

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@notnownikki notnownikki mentioned this pull request Jul 20, 2018
0 of 2 tasks complete
@notnownikki notnownikki requested review from youknowriad and gziolo Jul 20, 2018
@notnownikki notnownikki force-pushed the update/edit-embed-url branch from 4b93506 to c1a0503 Jul 24, 2018
@notnownikki
Copy link
Member Author

notnownikki commented Jul 24, 2018

Rebased to pick up the alignment toolbar changes

@gziolo
Copy link
Member

gziolo commented Jul 26, 2018

Code wise it looks good. However, there is some visual issue which needs to be fixed before we proceed:

screen shot 2018-07-26 at 12 50 05

Browser: Chrome, macOS.

Copy link
Member

gziolo left a comment

Code wise it looks good. However, there are some visual issues which need to be fixed before we proceed:

screen shot 2018-07-26 at 12 50 05

screen shot 2018-07-26 at 12 53 05

Browser: Chrome, macOS.

@notnownikki
Copy link
Member Author

notnownikki commented Jul 26, 2018

I wonder if this is an issue with mixing supports and BlockControls in the same block. I'll take a look!

@notnownikki
Copy link
Member Author

notnownikki commented Jul 26, 2018

Wrapped the edit control in Toolbar, seems to fix it. Perhaps I missed something in a past change, I'm sure this used to happen automatically...

@gziolo
gziolo approved these changes Jul 26, 2018
Copy link
Member

gziolo left a comment

Thanks for fixing, all good after your change. 🚢

@gziolo gziolo added this to the 3.4 milestone Jul 26, 2018
@notnownikki notnownikki merged commit ac89b86 into master Jul 26, 2018
2 checks passed
2 checks passed
codecov/project 50.77% (+1.89%) compared to a1bc317
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@youknowriad youknowriad deleted the update/edit-embed-url branch Jul 26, 2018
@mtias
Copy link
Contributor

mtias commented Aug 2, 2018

Nice small improvement, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.