Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRename Shared Blocks to Reusable Blocks #8123
Conversation
|
Can we go with Reusable? Ideally saying 'Save this block to reuse' as the call? Apologies but I think this would work better going forward @noisysocks based on feedback in that issue. |
|
There are some changes to public selectors and actions, should we add deprecation note? |
noisysocks
changed the title
|
I've updated this to use 'reusable', changed the copy of the UI controls to match what Kjell suggested in #7887 (comment), and added deprecated aliases for the public selectors, actions and block API. |
| role={ itemsRole } | ||
| > | ||
| { __( 'Delete Shared Block' ) } | ||
| { __( 'Remove from Reusable Blocks' ) } |
This comment has been minimized.
This comment has been minimized.
youknowriad
Jul 26, 2018
Contributor
This one is a bit confusing to me. I understand better "Remove reusable block" but I can see how the ambiguity there too.
|
LGTM |
|
Gonna merge this to get ahead of merge conflicts |
|
Any deprecations should be added to https://wordpress.org/gutenberg/handbook/reference/deprecated/ The functions deprecated here do not appear there and thus plugin authors who reference this page would not have the advance notice to have updated their usage. |
| return updateReusableBlockTitle( id, title ); | ||
| } | ||
|
|
||
| export function convertBlockToSaved( clientId ) { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
noisysocks commentedJul 23, 2018
•
edited
This is the first half of #7887.
Renames all 'shared block' references to 'reusable block', and changes the copy of the associated UI controls to match what was suggested in #7887 (comment).
To test: