New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margin-bottom from last element #8175

Merged
merged 3 commits into from Aug 22, 2018

Conversation

Projects
None yet
3 participants
@Soean
Member

Soean commented Jul 24, 2018

Description

Removes the margin-bottom from the last element in the panel body and control help texts.
Fixes #8174

Screenshots

Before:
bildschirmfoto 2018-07-24 um 18 36 56

After:
bildschirmfoto 2018-07-24 um 18 37 04

@Soean Soean added the [Type] Bug label Jul 24, 2018

@Soean Soean self-assigned this Jul 24, 2018

@chrisvanpatten

This comment has been minimized.

Show comment
Hide comment
@chrisvanpatten

chrisvanpatten Jul 24, 2018

Contributor

I just pushed #8183 which also touches this file, but I tested quickly (in-browser) and both PRs should work well together!

Contributor

chrisvanpatten commented Jul 24, 2018

I just pushed #8183 which also touches this file, but I tested quickly (in-browser) and both PRs should work well together!

@Soean

This comment has been minimized.

Show comment
Hide comment
@Soean

Soean Aug 21, 2018

Member

@aduth Thanks for your review, I updated the code.

Member

Soean commented Aug 21, 2018

@aduth Thanks for your review, I updated the code.

@aduth

aduth approved these changes Aug 21, 2018

👍

@@ -9,4 +9,5 @@
.components-base-control__help {
font-style: italic;
margin-bottom: 0;

This comment has been minimized.

@aduth

aduth Aug 21, 2018

Member

If it weren't the last item, would we still want for it to have no bottom margin?

Edit: Upon further investigation, I'd say that yes, it's correct as we've implemented here, since it's always the last child of a components-base-control which itself will apply the margin unless being the last child.

@aduth

aduth Aug 21, 2018

Member

If it weren't the last item, would we still want for it to have no bottom margin?

Edit: Upon further investigation, I'd say that yes, it's correct as we've implemented here, since it's always the last child of a components-base-control which itself will apply the margin unless being the last child.

@Soean Soean added this to the 3.7 milestone Aug 21, 2018

@Soean Soean merged commit 5745516 into master Aug 22, 2018

2 checks passed

codecov/project 50.89% (+2.14%) compared to f508995
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Soean Soean deleted the fix/8174-panel-bottom-padding branch Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment