Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix block validation: wrap in exception handler for malformed HTML #8304
In some final testing, I happened to stumble upon an interesting issue.
I'd have expected that since I already chose to "Keep as HTML", I would no longer be presented with this prompt. I assume what's happening is that the malformed markup is triggering the invalidation on the HTML block.
I'm not entirely sure how we accommodate this:
I'm also open to merging this one as-is, since the current state is an improvement over the previous error.
Ah yes, interesting!
I tried it with the previous code and the editor just white-screens. I'll merge this as an improvement over the current situation, and file a ticket for the invalid-on-load separately.
A different error message sounds a good idea regardless. I also like the idea of not validating certain blocks - if the user wants the invalid HTML then that's fine. I've been looking at tweaking the validation for other blocks, so this would be a good use case.