New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Update RichText usage to avoid inline elements #8785

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
2 participants
@nfmohit-wpmudev
Contributor

nfmohit-wpmudev commented Aug 9, 2018

Description

This PR closes #8773 which reports the incompatibility of inline RichText elements and TinyMCE.

How has this been tested?

This PR has been tested by going through the following steps:

  1. Started a new post using the Gutenberg editor.
  2. Added a quote/pull-quote block with some text.
  3. Made sure everything is functional and the styling is unchanged even though inline tags (cite) are replaced with block-level elements (div).

This was tested in WP 4.9.8, Gutenberg 3.4.0, Apache server with PHP 7.2.0 and MySQL 5.6.34. According to initial tests, the code doesn’t seem to affect any other areas.

Screenshots

pull-8773-min

Types of changes

This PR omits the tagName properties in the citations for the quote and pull-quote blocks so that they convert to using div tags instead of cite. It also updates styling to make sure the blocks look unchanged.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
Show outdated Hide outdated core-blocks/pullquote/index.js Outdated
Show outdated Hide outdated core-blocks/pullquote/theme.scss Outdated
@aduth

This comment has been minimized.

Show comment
Hide comment
@aduth

aduth Aug 13, 2018

Member

I think merging in master went poorly here. You might have more luck with git rebase origin/master.

Feel free to ping me on Slack if you need assistance.

Member

aduth commented Aug 13, 2018

I think merging in master went poorly here. You might have more luck with git rebase origin/master.

Feel free to ping me on Slack if you need assistance.

@nfmohit-wpmudev

This comment has been minimized.

Show comment
Hide comment
@nfmohit-wpmudev

nfmohit-wpmudev Aug 16, 2018

Contributor

Not sure what was going on with rebase. Tried different workarounds, but ended up with resetting the branch and doing the changes again. Looking forward to another review. Thank you @aduth ❤️

Contributor

nfmohit-wpmudev commented Aug 16, 2018

Not sure what was going on with rebase. Tried different workarounds, but ended up with resetting the branch and doing the changes again. Looking forward to another review. Thank you @aduth ❤️

@aduth

aduth approved these changes Sep 10, 2018

Apologies for the delay in revisiting this for review. It works great! Thanks for the patience and the work here 👍

@aduth aduth added this to the 3.9 milestone Sep 10, 2018

@aduth aduth merged commit 47cd11f into WordPress:master Sep 10, 2018

2 checks passed

codecov/project 50.67% remains the same compared to 837d908
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment